Skip to content

Remove cache in publish#522

Open
andrew-fleming wants to merge 5 commits into
OpenZeppelin:mainfrom
andrew-fleming:remove-cache-in-publish
Open

Remove cache in publish#522
andrew-fleming wants to merge 5 commits into
OpenZeppelin:mainfrom
andrew-fleming:remove-cache-in-publish

Conversation

@andrew-fleming
Copy link
Copy Markdown
Contributor

@andrew-fleming andrew-fleming commented May 21, 2026

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows and setup processes to optimize build and release pipeline configuration.

Review Change Stack

@andrew-fleming andrew-fleming requested review from a team as code owners May 21, 2026 21:31
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5cd3c4bb-831b-4008-9b27-a46f0c788584

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR reorders GitHub Actions steps to ensure Node.js setup via actions/setup-node runs before Corepack enablement across three configuration files. The composite setup action, prepare-release workflow, and release workflow are updated to reflect consistent step ordering, replacing a custom "Setup Environment" action with explicit setup and build steps in the release workflow.

Changes

GitHub Actions step ordering

Layer / File(s) Summary
Corepack step reordering in setup action and workflows
.github/actions/setup/action.yml, .github/workflows/prepare-release.yml, .github/workflows/release.yml
The composite setup action moves Corepack enablement from before to after Node.js setup. The prepare-release workflow reverses its step order to set up Node.js before enabling Corepack. The release workflow replaces a custom "Setup Environment" action with explicit actions/setup-node, corepack enable, yarn install --immutable, and yarn turbo build steps in the same order.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through workflows with glee, 🐰
Reordering steps so they dance in harmony.
Node.js first, then Corepack's turn,
Dependencies flow—no more stumbling or churn!
Consistency wins when the order's just right. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Remove cache in publish' is vague and doesn't clearly describe the actual changes, which involve reordering workflow steps to move 'Enable corepack' later and updating Node.js/dependency setup. Consider a more descriptive title that captures the main change, such as 'Reorder workflow steps: enable corepack after Node.js setup' or 'Restructure CI workflows for Node.js and dependency setup'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/actions/setup/action.yml (1)

22-22: 💤 Low value

Consider updating to setup-node v6.4.0 for consistency.

The workflows in prepare-release.yml and release.yml use actions/setup-node v6.4.0, while this composite action uses v6.1.0. Aligning to the same version across all workflows would improve maintainability.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/actions/setup/action.yml at line 22, Update the actions/setup-node
reference used in this composite action: replace the current uses:
actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f (v6.1.0) with uses:
actions/setup-node@v6.4.0 so it matches the version used in prepare-release.yml
and release.yml for consistency across workflows.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/actions/setup/action.yml:
- Line 22: Update the actions/setup-node reference used in this composite
action: replace the current uses:
actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f (v6.1.0) with uses:
actions/setup-node@v6.4.0 so it matches the version used in prepare-release.yml
and release.yml for consistency across workflows.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c411bbe4-d2ac-4053-8729-5e82f3c304f2

📥 Commits

Reviewing files that changed from the base of the PR and between de13830 and 9636e8a.

📒 Files selected for processing (3)
  • .github/actions/setup/action.yml
  • .github/workflows/prepare-release.yml
  • .github/workflows/release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant