Repository navigation
fix(lighting): validate hue and saturation bounds in OWNLightingCommand.hs - #125
Merged
Merged
Conversation
…n OWNLightingCommand.hs
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
GreenGrassBlueOcean
force-pushed
the
fix/lighting-hs-validation
branch
from
October 16, 2026 22:11
6e375b3 to
7b26bbe
Compare
fedem95
approved these changes
Oct 16, 2026
fedem95
left a comment
fedem95
left a comment
Contributor
There was a problem hiding this comment.
Approved. The hue and saturation bounds are now validated, and the added tests cover the previously missing invalid values. No further concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #123 addressing @fedem95's review note (PR #123 review).
Summary
OWNLightingCommand.hsvalidation to require0 <= h <= 360and0 <= s <= 100(rejecting negative hue and out-of-range saturation values).tests/test_who1_ts10_builders.pycovering negative hue (-1) and out-of-range saturation (-1,101).