Skip to content

refactor(protocol): eliminate private OWNd access and runtime shims (#736) - #737

Merged
GreenGrassBlueOcean merged 7 commits into
v2-phase1-architecturefrom
arch/issue-736-protocol-boundary-cleanup
Oct 16, 2026
Merged

GreenGrassBlueOcean merged 7 commits into
v2-phase1-architecturefrom
arch/issue-736-protocol-boundary-cleanup

Conversation

@GreenGrassBlueOcean

@GreenGrassBlueOcean GreenGrassBlueOcean commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Closes #736

Summary

  • Delegate WHO=1 APL address helpers (is_apl_address, area_of_where, normalize_where), WHO=1 timed turn-on builders, WHO=1 group dimension properties (brightness, color_temp_kelvin, hs_color), WHO=4 temperature decoding (who4_temperature), and WHO=16 stepped volume decoding (volume_step_delta) to OWNd 2.0.0b11 (OpenWebNet-HA/OWNd#123).
  • Replace all private _dimension_value accesses across custom_components/myhome/ with the public dimension_value property.
  • Remove all type(x).__name__ == 'MagicMock' checks from production code (sensor.py, gateway_events.py, gateway_resync.py, services.py).
  • Remove obsolete _StatusRequestLogFilter and platform-scattered ImportError constant shims; consolidate the temporary OWNd < 2.0.0b11 compatibility bridge into where_grammar.py until OWNd==2.0.0b11 is published to PyPI.
  • Add AST/source guards in tests/test_where_usage_guard.py preventing future MagicMock or _dimension_value regressions in production code.

@GreenGrassBlueOcean GreenGrassBlueOcean changed the title refactor(protocol): eliminate OWNd boundary leaks and MagicMock checks (#736) refactor(protocol): eliminate private OWNd access and runtime shims (#736) Oct 16, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@GreenGrassBlueOcean
GreenGrassBlueOcean merged commit 5d9218d into v2-phase1-architecture Oct 16, 2026
18 of 22 checks passed
@GreenGrassBlueOcean
GreenGrassBlueOcean deleted the arch/issue-736-protocol-boundary-cleanup branch October 16, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants