Repository navigation
test(sound): replay live MH200 + L4561N trace; send tuner frequency unpadded - #662
Merged
GreenGrassBlueOcean merged 1 commit intoOct 8, 2026
Merged
Conversation
…npadded Adds the 2026-10-07 recording from the MH200 2.0.32 plant (L4561N as source 102, zone 21) with a replay test, so it runs in CI: - the frames MyHOMESoundSource builds (on, off, next/previous, preset write) are the ones that went out on the plant; - source 102 reports on throughout, zone 21 off at volume 0. The capture is filtered on WHO 16 and WHERE 102/21, so it holds no ACK/NACK; the README says so. async_set_frequency no longer zero-pads: the F500N capture (#427) shows *#16*101*#6*0*96200## accepted, and nothing uses the padded form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/fixtures/traces/mh200_l4561n_source/. The L4561N stereo control is source 102; zone 21 is in environment 2. The trace has a README.tests/test_l4561n_source_trace_replay.py, so the trace runs in CI. It checks that:MyHOMESoundSourcebuilds (on, off, next/previous, preset write*#16*102*#7*n##) are exactly the ones that went out on the plant;*16*3*102##(on) throughout, and the entity stays on;async_set_frequencyno longer zero-pads: 96.2 MHz is now sent as*#16*101*#6*0*96200##, not…*096200##. That form is the one the F500N capture in feat(media_player): tuner entity for WHO=16 sound sources (F500) #427 shows working. No capture or oracle row uses the padded form. The spec's "6 digits" comes only with the example107000, where padding changes nothing. This is the same fix as in OWNd#95, raised by fedem95 in this review.What the trace does not show
The capture is filtered on WHO 16 and WHERE 102/21, so the gateway's
*#*1##/*#*0##replies are not in it. It shows that these frames were sent on a real plant. It does not show that the gateway ACKed them. None of the commands changed the reported state: source 102 stayed on after the off commands, and zone 21 stayed off after*16*0*21##. The fixture's README spells this out. The same file is in own-firmware-oracle#25 as the live counterpart of the emulated WHO 16 suite.Tests
Against the pinned
OWNd==2.0.0b10:ruff check,verify_ha_standards.pyandsync_documentation.py --checkare clean.🤖 Generated with Claude Code