Repository navigation
Conversation
MSYS2's zlib 1.4 package links -lz to libz-1.dll, so Ruby's zlib extension imports that DLL. The package still has a zlib1.dll, but it is a separate legacy build that the extension doesn't use. Copying it left zlib unloadable on Windows in openvox-agent 9.4.0. Fixes #350 Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com>
Ruby 3.2 built readline.so against Cygwin's mingw readline, but the runtime never contained libreadline7.dll, so the extension could not load and readline.rb fell back to Reline. Without the readline package the extension isn't built and Reline is used the same way. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com>
A DLL from the build toolchain loads during the build, where the toolchain's bin directory is on PATH, so a runtime that leaves one out still builds and only fails on other machines. That is how the 2026.11.12.1 runtime shipped a zlib.so that needs libz-1.dll. After the vanagon build, check every packaged binary with objdump and abort when it imports a DLL that is in the toolchain's bin directory but not in the package. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com>
Member
Author
|
Tests to make sure this works on Windows, since the PR checks don't build Windows |
Sharpie
approved these changes
Nov 17, 2026
Sharpie
left a comment
Member
There was a problem hiding this comment.
Looks correct, and matches the change that RubyInstaller made upstream:
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSYS2's zlib 1.4 package links -lz to libz-1.dll, so Ruby's zlib
extension imports that DLL. The package still has a zlib1.dll, but it
is a separate legacy build that the extension doesn't use. Copying it
left zlib unloadable on Windows in openvox-agent 9.4.0.
Additionally, Ruby 3.2 built readline.so against Cygwin's mingw readline, but the
runtime never contained libreadline7.dll, so the extension could not
load and readline.rb fell back to Reline. Without the readline package
the extension isn't built and Reline is used the same way.
Lastly, this adds a check to the build task to ensure we aren't shipping without
required DLLs.