Conversation
🤖 Augment PR SummarySummary: Adds a new QuartzCore-backed Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| contents = layerContents | ||
| backgroundColor = bgColor | ||
| allowsEdgeAntialiasing = image.isAntialiased | ||
| guard contents != nil else { return } |
There was a problem hiding this comment.
update(image:size:) returns early when contents is nil, but that leaves prior image-related state (e.g. contentsMultiplyColor, contentsScaling, filters, EDR flags) untouched and potentially leaking across updates (e.g. when switching to .color). Consider explicitly resetting any stateful content-related properties before returning so the layer can’t carry stale configuration forward.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| let currentMaxEDR = wasUsingEDR ? contentsMaximumDesiredEDR : 1.0 | ||
|
|
||
| // Enable EDR if needed | ||
| if headroom > .standard { |
There was a problem hiding this comment.
When headroom drops back to .standard, wantsExtendedDynamicRangeContent is never set back to false, so a layer that previously displayed HDR content may remain in EDR mode. That can make subsequent SDR (or background-color-only) updates behave differently than intended.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
|
||
| struct GraphicsImageLayerStretchTests { | ||
| // Helper to create a basic GraphicsImage for testing | ||
| private func makeImage( |
There was a problem hiding this comment.
The new stretch/tile math depends on scale and orientation (via bitmapOrientation), but the current argument sets mostly exercise .up and scale 1. Adding at least one non-.up orientation case and a non-1.0 scale case would help catch regressions in the normalization logic.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
===========================================
+ Coverage 13.43% 26.75% +13.32%
===========================================
Files 617 647 +30
Lines 35960 39386 +3426
===========================================
+ Hits 4832 10539 +5707
+ Misses 31128 28847 -2281 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.