Replace clone-swift.sh with git submodule for Swift headers#217
Merged
Replace clone-swift.sh with git submodule for Swift headers#217
Conversation
Swift headers are now provided via the Checkouts/swift git submodule, so the manual clone script, build tool plugin, and CI action are no longer needed.
🤖 Augment PR SummarySummary: This PR replaces the Swift-header bootstrap mechanism with a pinned git submodule. Changes:
Technical Notes: Builds now assume headers are already present at 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
- Coverage 32.08% 31.47% -0.62%
==========================================
Files 70 70
Lines 2596 2596
==========================================
- Hits 833 817 -16
- Misses 1763 1779 +16
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checkouts/swiftas a git submodule pointing to OpenSwiftUIProject/swift-runtime-headers (release/6.1branch)submodules: trueto allactions/checkout@v4steps in CI workflowsScripts/clone-swift.sh,Plugins/CloneSwiftPlugin, and.github/actions/checkout-swift-headers— no longer neededTest plan
git clone --recurse-submodulesworks for fresh clonesswift buildsucceeds without--disable-sandbox