Skip to content

Replace clone-swift.sh with git submodule for Swift headers#217

Merged
Kyle-Ye merged 3 commits intomainfrom
feature/submodule
Feb 25, 2026
Merged

Replace clone-swift.sh with git submodule for Swift headers#217
Kyle-Ye merged 3 commits intomainfrom
feature/submodule

Conversation

@Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Feb 25, 2026

Summary

  • Add Checkouts/swift as a git submodule pointing to OpenSwiftUIProject/swift-runtime-headers (release/6.1 branch)
  • Add submodules: true to all actions/checkout@v4 steps in CI workflows
  • Remove Scripts/clone-swift.sh, Plugins/CloneSwiftPlugin, and .github/actions/checkout-swift-headers — no longer needed
  • Bump version to 6.5.1 and enable apple-generic versioning

Test plan

  • Verify CI workflows pass with submodule checkout
  • Verify git clone --recurse-submodules works for fresh clones
  • Verify swift build succeeds without --disable-sandbox

Swift headers are now provided via the Checkouts/swift git submodule,
so the manual clone script, build tool plugin, and CI action are no
longer needed.
@github-actions github-actions bot added enhancement New feature or request build issue labels Feb 25, 2026
@augmentcode
Copy link

augmentcode bot commented Feb 25, 2026

🤖 Augment PR Summary

Summary: This PR replaces the Swift-header bootstrap mechanism with a pinned git submodule.

Changes:

  • Add Checkouts/swift as a submodule pointing to OpenSwiftUIProject/swift-runtime-headers (release/6.1) and pin the commit.
  • Update CI workflows to checkout submodules via actions/checkout@v4 (submodules: true).
  • Remove the custom checkout action (.github/actions/checkout-swift-headers), Scripts/clone-swift.sh, and the SwiftPM build-tool plugin (CloneSwiftPlugin).
  • Adjust .gitignore so only the Swift-headers submodule is kept under Checkouts/.
  • Update README instructions to initialize the headers via git submodule update --init.

Technical Notes: Builds now assume headers are already present at Checkouts/swift (no plugin-driven cloning / sandbox workaround).

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

# Option 2: Let the build plugin clone headers (requires --disable-sandbox)
swift build --disable-sandbox
git submodule update --init
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider documenting git submodule update --init --recursive (and/or git clone --recurse-submodules) here so nested submodules won’t be missed if they’re introduced later.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@Kyle-Ye Kyle-Ye merged commit 8a20ed2 into main Feb 25, 2026
10 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/submodule branch February 25, 2026 20:09
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.47%. Comparing base (6c04001) to head (06cd691).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   32.08%   31.47%   -0.62%     
==========================================
  Files          70       70              
  Lines        2596     2596              
==========================================
- Hits          833      817      -16     
- Misses       1763     1779      +16     
Flag Coverage Δ
ios 31.48% <ø> (-0.62%) ⬇️
macos 9.95% <ø> (ø)
ubuntu 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build issue enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant