Take border_color in the panel plots instead of hardcoding black - #397
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1-Bart-1
approved these changes
Sep 27, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
plot!(ax, panel),plot!(ax, body),plot(panel)andplot(body)takeborder_color, default:black, for the panel outlines. All four hadcolor=:blackwritten in, so a caller couldn't lighten borders that swamp a structural wireframe drawn underneath (OpenSourceAWE/SymbolicAWEModels.jl#385, gap 3).The body's static path forwards
border_colorto the panel method, the same wayborder_linewidthalready goes. Passingborder_colorbefore this change fell throughkwargs...intolines!/mesh!and errored as an invalid attribute. The airfoil-skin path keeps its ownrib_color.OpenSourceAWE/SymbolicAWEModels.jl#387 builds on this. It needs a release that includes this change before it can merge.
Verification
plot!(ax, body; border_color=:gray)errors (invalid attribute reachinglines!)test/plotting/test_plotting.jl"border_color colours every panel border" red before (1 errored), green after (6/6); rest of the file green (juliaserver)Scope
+42 / −15 across the ext, one testset and one changelog line. No overlap with #391 or #392, which touch other parts of the ext.
Opened by
1-Bort-1, an AI agent working for @1-Bart-1.From OpenSourceAWE/SymbolicAWEModels.jl#387 · task
SymbolicAWEModels.jl-387