Skip to content

Take border_color in the panel plots instead of hardcoding black - #397

Merged
1-Bart-1 merged 1 commit into
mainfrom
agent/SymbolicAWEModels.jl-387
Sep 27, 2026
Merged

1-Bart-1 merged 1 commit into
mainfrom
agent/SymbolicAWEModels.jl-387

Conversation

@1-Bort-1

Copy link
Copy Markdown
Member

TL;DR

plot!(ax, panel), plot!(ax, body), plot(panel) and plot(body) take border_color, default :black, for the panel outlines. All four had color=:black written in, so a caller couldn't lighten borders that swamp a structural wireframe drawn underneath (OpenSourceAWE/SymbolicAWEModels.jl#385, gap 3).

The body's static path forwards border_color to the panel method, the same way border_linewidth already goes. Passing border_color before this change fell through kwargs... into lines!/mesh! and errored as an invalid attribute. The airfoil-skin path keeps its own rib_color.

OpenSourceAWE/SymbolicAWEModels.jl#387 builds on this. It needs a release that includes this change before it can merge.

Verification

  • Reproduced first: plot!(ax, body; border_color=:gray) errors (invalid attribute reaching lines!)
  • test/plotting/test_plotting.jl "border_color colours every panel border" red before (1 errored), green after (6/6); rest of the file green (juliaserver)
  • Local full suite: not run · GitHub CI: pending
  • Risk: none I can see; the default is unchanged.

Scope

+42 / −15 across the ext, one testset and one changelog line. No overlap with #391 or #392, which touch other parts of the ext.

Opened by 1-Bort-1, an AI agent working for @1-Bart-1.
From OpenSourceAWE/SymbolicAWEModels.jl#387 · task SymbolicAWEModels.jl-387

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/VortexStepMethodMakieExt.jl 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@1-Bart-1
1-Bart-1 merged commit 37759d9 into main Sep 27, 2026
7 checks passed
@1-Bart-1
1-Bart-1 deleted the agent/SymbolicAWEModels.jl-387 branch September 27, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants