Since #393 forms alpha with inflow_angle(v, y_airf, z_airf), nothing in calculate_results reads its x_airf_dist and z_airf_dist positional arguments (src/body_aerodynamics.jl, the signature at function calculate_results(). The only in-repo callers are solve_base! in src/solver.jl and test/bench.jl, and both pass buffers that exist only for these two slots.
calculate_results is exported, so dropping the two arguments is a breaking change and was left out of #393. What I would do: remove both from the signature and the two callers, BREAKING: in the changelog, in whichever release next takes a breaking change. #94 (removing the results dict) rewrites the same function and is the natural place to fold it in.
Since #393 forms alpha with
inflow_angle(v, y_airf, z_airf), nothing incalculate_resultsreads itsx_airf_distandz_airf_distpositional arguments (src/body_aerodynamics.jl, the signature atfunction calculate_results(). The only in-repo callers aresolve_base!insrc/solver.jlandtest/bench.jl, and both pass buffers that exist only for these two slots.calculate_resultsis exported, so dropping the two arguments is a breaking change and was left out of #393. What I would do: remove both from the signature and the two callers,BREAKING:in the changelog, in whichever release next takes a breaking change. #94 (removing the results dict) rewrites the same function and is the natural place to fold it in.