Dev stage fixes#275
Open
MagueresMathieu wants to merge 2 commits into
Open
Conversation
added 2 commits
April 30, 2026 10:21
…ove unserialized elements to 'Unstable' category
LANDAISB
requested changes
May 29, 2026
| ToAlbum. | ||
| ToTextField. | ||
| ToListElement. }. | ||
| knownNotUsable := #( #ToCircularMenuInnerElement |
| elements: (okElements sorted: [ :a :b | a name < b name ]); | ||
| yourself). | ||
| (PyramidLibraryCategory new | ||
| name: 'Unstable'; |
Contributor
There was a problem hiding this comment.
Maybe 'Toplo' and 'Unstable' not good names. ''Toplo-Verified' and 'Toplo-Unverified' ?
| ^ { | ||
| (PyramidLibraryCategory new | ||
| name: 'Toplo'; | ||
| icon: (Smalltalk ui icons iconNamed: #box); |
Contributor
There was a problem hiding this comment.
Another icon ? With a check ?
| ToImage. | ||
| ToAlbum. | ||
| ToTextField. | ||
| ToListElement. }. |
Contributor
There was a problem hiding this comment.
ToAlbum and ToListElement are functional ?
| { #category : #accessing } | ||
| PyramidLibraryElement >> status [ | ||
|
|
||
| ^ status ifNil: [ #ok ] |
| ] | ||
|
|
||
| { #category : #accessing } | ||
| PyramidLibraryElement >> status: aSymbol [ |
Contributor
There was a problem hiding this comment.
the different status should be defined on class methods (instead of calling #ok or #unstable, call PyramidLibraryElement statusUnstable). Easier to maintain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.