Adjust same space for change recommendations#6000
Open
Borreg0 wants to merge 1 commit intoOpenSlides:mainfrom
Open
Adjust same space for change recommendations#6000Borreg0 wants to merge 1 commit intoOpenSlides:mainfrom
Borreg0 wants to merge 1 commit intoOpenSlides:mainfrom
Conversation
MSoeb
requested changes
Mar 18, 2026
MSoeb
left a comment
MSoeb
left a comment
There was a problem hiding this comment.
The space looks fine, but a strange bug occurs.
When I recreate the pull request with the change recommendation as described in the issue and then enter another change reco in the first line, lines 1 and 2 overlap.
To make sure this is a bug that only occurs in this pull request, I tested it on the current live version as well as on the internal 4.3-transitional branch. The problem does not occur in either version. I suspect there is a connection to this pull request.
To reproduce the error, a change reco must be entered in the first line. Whether words are deleted or added, the error occurs in
Here is a screenshot of the error:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5915