Skip to content

Conversation

@dmataCap
Copy link
Contributor

Add a description

LogicalLane message was extended to support road type information from OpenDRIVE.

Some questions to ask:
What is this change?

  • An additional enum type and the respective message extension.

What does it fix?

  • Missing road type information to determine the speed limit and to easily display a road in a navigation system.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

@thempen thempen added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Feb 15, 2023
@thomassedlmayer
Copy link
Contributor

Harmonization WG 2023/03/01: Won't adapt any changes from OpenDrive if there are still changes going on in OpenDrive (see 'Overlapping bike lane with lanes' topic).

@tbleher
Copy link
Contributor

tbleher commented Oct 29, 2025

Is there anything I can do to help this topic be merged? I need this data for simulation of traffic agents.

@asadekasam
Copy link

OSI CCB 2025.10.30: @tbleher Could you check that the definitions here still match current OpenDRIVE?

@tbleher
Copy link
Contributor

tbleher commented Oct 31, 2025

OSI CCB 2025.10.30: @tbleher Could you check that the definitions here still match current OpenDRIVE?

Sure 😃

I checked with OpenDRIVE 1.8.1 (the currently released OpenDRIVE version), and the enum matches OpenDRIVE exactly (except that OSI has a ROAD_TYPE_OTHER, that OpenDRIVE doesn't have, but my understanding is that all OSI enums have a ..._OTHER value, and ..._OTHER does not have to be in OpenDRIVE).

I'm part of the OpenDRIVE CCB, and so far we have not received requests to add new road types or modify existing types. I do not also see any active Pull Request adding or changing the roadType.

@tbleher
Copy link
Contributor

tbleher commented Nov 24, 2025

@asadekasam and @pmai Could this commit be merged? Any input from the CCB on what is still missing from this PR?

@asadekasam
Copy link

@asadekasam and @pmai Could this commit be merged? Any input from the CCB on what is still missing from this PR?

I will add it to this week's CCB then (Thursday 2025.11.27)

@asadekasam asadekasam added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Nov 24, 2025
The road type is useful since traffic participant models might want to
influence their behavior based on the type of road that they are driving
on, or make decisions in terms of navigation based on that information.
It is also helpful to display a road in a navigation system, as
typically different road types are displayed differently.

Signed-off-by: Daniel Mata <Daniel.Mata@partner.bmw.de>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by CCB on 2025-11-27 after fixes.

@pmai pmai merged commit 3ae2a04 into OpenSimulationInterface:master Nov 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Harmonisation The Group in the ASAM development project working on harmonisation with other standards. ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants