Introducing new color models #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think h (in hsv) has a value from 0 to 360; and v (in hsv) might also has a value from -1 to 1. |
thomassedlmayer
added
the
Harmonisation
thomassedlmayer
changed the title
thomassedlmayer
added
the
ReadyForCCBReview
Contributor
|
OSI CCB:
|
stefancyliax
added
Documentation
pasched
approved these changes
Aug 31, 2021
HendrikAmelunxen
added
the
ReadyToMerge
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
pmai
force-pushed
the
feature/ha/new-color-models
branch
from
05d0d2d to
e7bf055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Sedlmayer tsedlmayer@pmsfit.de
Description
This PR emerged from the Harmonisation group and the discussions related to #512. It should serve as a basis for further discussion. The color models (Grey, RGB, RGBIR, HSV, LUV) were adopted from the ISO-23150.
It is not completely clear yet where and how to apply the new message and how to manage the transition to complement or replace existing color enums. As a result from discussions, color enums that represent semantic meaning (e.g. traffic light colors, lane marking colors, lane boundary colors) should probably be kept as is or could be unified as separate enums (e.g. "SemanticColors"). Semantic colors are colors that specifically specify an objects meaning in traffic and do not necessarily represent its visual color. E.g. a lane boundary that is semantically classified as orange does not have to be visually orange (e.g. washed out to white). Hence, we should clearly differentiate semantic colors from visual colors that represent appearance only.
Color enums for stationary objects and camera detections could be complemented (short-term) or replaced (long-term) with the new ColorDescription. Also, moving objects do not have a color field yet and could also contain the new ColorDescription.
The name of the message (ColorDescription) is still under discussion.