Camera detecions #298
Merged
Camera detecions #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proposal for camera detections
carsten-kuebler
added
the
FeatureRequest
AutoBrief = NO AutoBrief = YES will not generate a complete list of all members of a message in the extended documentation. Members without additional documentation will be skipped.
ghost
reviewed
Dec 21, 2018
ghost
suggested changes
Dec 21, 2018
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM except for the comment. Did the "camera guys" approve this implementation and did they review the .proto files?
Contributor
Author
|
I sent Thomas the proposal. It equals the ISO proposal (except of OSI specific terms, objects and so on, and a second documentation). |
ghost
approved these changes
Dec 21, 2018
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CarloVanDriestenBMW: Proposal for camera detections.