Skip to content

Conversation

@carsten-kuebler
Copy link
Contributor

Images in Lanes and Lane Boundaries.

Images in Lanes and Lane Boundaries.
@carsten-kuebler carsten-kuebler requested a review from a user November 8, 2018 11:43
@ghost ghost added this to the v3.1.0 milestone Nov 9, 2018
@ghost ghost added the Documentation Everything which impacts the quality of the documentation and guidelines. label Nov 9, 2018
@ghost
Copy link

ghost commented Nov 9, 2018

Comments for pictures:

  1. OSI_BaseStationary.jpg, design (colors...etc), what kind of picture is there inside, base polygon is not understandable
  2. Pictures in general: If I show the picture to a random person it needs all information necessary to understand the picutre.
  3. Some images are duplicated

Requirements

  1. A picture should emphasise and visually support the property of a message/object which the hardest to understand for the user:
    example: Detected objects are complicated in terms of coordinate transformations and their concept of "candidates". Candidates my be hard to visualize therefore the coordinate transformation could be shown including the FOV, a sensor, and the reference points (pysical/virtual mounting position).
  2. The idea of reusing an image is good - maybe the different sections within the picture explaining a specific element can be "zoomed in" or something similar? The information for supplementary traffic signes are hard to see because they are very small compared to the whole picture.
  3. The size of the images should be accoring to the requirements.
  4. The plant in BaseStationary could be a different picture.

@ghost
Copy link

ghost commented Nov 20, 2018

The images should be vector graphics. Positive Example

Comparing both styles it is much cleaner for a professional documentation and does not distract the reader too much.

@ghost
Copy link

ghost commented Dec 14, 2018

@carsten-kuebler merge conflict

Additional figures and updated figures and documentation
@carsten-kuebler
Copy link
Contributor Author

@CarloVanDriestenBMW please review the figures and documentation.

@carsten-kuebler
Copy link
Contributor Author

@CarloVanDriestenBMW We leave some rendered images in the documentation, because the corresponding figures are missing at the moment. Mr. Schreiner could design new figures next year.

@ghost
Copy link

ghost commented Dec 14, 2018

@carsten-kuebler still conflicting

yes, we can draft the images beginning of next year.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 98b31b3 into master Dec 14, 2018
@ghost ghost deleted the documentation/lane_images branch December 14, 2018 20:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Everything which impacts the quality of the documentation and guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants