Skip to content

Commit e519f52

Browse files
committed
checked for plural forms and added notice for singular usage
1 parent 56d0c15 commit e519f52

File tree

4 files changed

+32
-4
lines changed

4 files changed

+32
-4
lines changed

osi_detectedlane.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,17 +127,17 @@ message DetectedLaneBoundary
127127
// The root mean squared error of the \c LaneBoundary.BoundaryPoint
128128
// information from a \c LaneBoundary.
129129
// For each \c #lane_boundary \c LaneBoundary::boundary_line point exact
130-
// one \c #boundary_line_points_rmse rmse information exist.
130+
// one \c #boundary_line_rmse rmse information exist.
131131
//
132-
repeated LaneBoundary.BoundaryPoint boundary_line_points_rmse = 2;
132+
repeated LaneBoundary.BoundaryPoint boundary_line_rmse = 2;
133133

134134
// Confidence of the segments of the \c LaneBoundary.BoundaryPoint
135135
// information from a \c LaneBoundary.
136136
// For each \c #lane_boundary \c LaneBoundary::boundary_line point exact
137-
// one \c #boundary_line_points_confidences confidence value is
137+
// one \c #boundary_line_confidences confidence value is
138138
// specified.
139139
//
140-
repeated double boundary_line_points_confidences = 3;
140+
repeated double boundary_line_confidences = 3;
141141

142142
//
143143
// \brief A candidate for a detected traffic sign as estimated by the

osi_sensordata.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ message SensorData
110110
// This provides a copy of the \c SensorView data received by the sensor
111111
// for reference purposes. For complex sensors or logic models this
112112
// can be multiple copies.
113+
//
114+
// \note OSI uses singular instead of plural for repeated field names.
113115
//
114116
repeated SensorView sensor_view = 6;
115117

osi_sensorview.proto

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,18 +112,26 @@ message SensorView
112112
optional Identifier host_vehicle_id = 8;
113113

114114
// Radar-Specific SensorView(s)
115+
//
116+
// \note OSI uses singular instead of plural for repeated field names.
115117
//
116118
repeated RadarSensorView radar_sensor_view = 1000;
117119

118120
// Lidar-Specific SensorView(s)
121+
//
122+
// \note OSI uses singular instead of plural for repeated field names.
119123
//
120124
repeated LidarSensorView lidar_sensor_view = 1001;
121125

122126
// Camera-Specific SensorView(s)
127+
//
128+
// \note OSI uses singular instead of plural for repeated field names.
123129
//
124130
repeated CameraSensorView camera_sensor_view = 1002;
125131

126132
// Ultrasonic-Specific SensorView(s)
133+
//
134+
// \note OSI uses singular instead of plural for repeated field names.
127135
//
128136
repeated UltrasonicSensorView ultrasonic_sensor_view = 1003;
129137
}

osi_sensorviewconfiguration.proto

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,15 +182,27 @@ message SensorViewConfiguration
182182
optional double simulation_start_time = 10;
183183

184184
// Radar-specific SensorView Configuration(s).
185+
//
186+
// \note OSI uses singular instead of plural for repeated field names.
187+
//
185188
repeated RadarSensorViewConfiguration radar_sensor_view_configuration = 1000;
186189

187190
// Lidar-specific SensorView Configuration(s).
191+
//
192+
// \note OSI uses singular instead of plural for repeated field names.
193+
//
188194
repeated LidarSensorViewConfiguration lidar_sensor_view_configuration = 1001;
189195

190196
// Camera-specific SensorView Configuration(s).
197+
//
198+
// \note OSI uses singular instead of plural for repeated field names.
199+
//
191200
repeated CameraSensorViewConfiguration camera_sensor_view_configuration = 1002;
192201

193202
// Ultrasonic-specific SensorView Configuration(s).
203+
//
204+
// \note OSI uses singular instead of plural for repeated field names.
205+
//
194206
repeated UltrasonicSensorViewConfiguration ultrasonic_sensor_view_configuration = 1003;
195207
}
196208

@@ -289,9 +301,15 @@ message RadarSensorViewConfiguration
289301
optional double emitter_frequency = 9;
290302

291303
// This represents the TX antenna diagram
304+
//
305+
// \note OSI uses singular instead of plural for repeated field names.
306+
//
292307
repeated AntennaDiagramEntry tx_antenna_diagram = 10;
293308

294309
// This represents the RX antenna diagram
310+
//
311+
// \note OSI uses singular instead of plural for repeated field names.
312+
//
295313
repeated AntennaDiagramEntry rx_antenna_diagram = 11;
296314

297315
//

0 commit comments

Comments
 (0)