Skip to content

Commit 96a0e3f

Browse files
ThomasNaderBMW0815-code
authored andcommitted
Add width and model_reference, correct descriptions
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
1 parent dc41cb8 commit 96a0e3f

File tree

1 file changed

+27
-9
lines changed

1 file changed

+27
-9
lines changed

osi_object.proto

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,8 @@ message MovingObject
458458

459459
// \brief Detailed wheel data.
460460
// The focus is on the description of a wheel regarding the perceivable
461-
// information from the outside.
461+
// information from the outside.
462+
// It is not intended to be used for e.g. dynamic calculations.
462463
//
463464
message WheelData
464465
{
@@ -473,6 +474,7 @@ message MovingObject
473474
//
474475
// For example, on a standard 2-axle, 4-wheel car, the rear-right
475476
// wheel would be (axle=1, index=0).
477+
// This concept works also for twin tires.
476478
//
477479
optional uint32 index = 2;
478480

@@ -483,37 +485,53 @@ message MovingObject
483485
//
484486
optional Vector3d position = 3;
485487

486-
// Median radius of the wheels measured from a center of the wheel to
488+
// Median radius of the wheel measured from the center of the wheel to
487489
// the outer part of the tire.
488490
//
489491
//
490492
// Unit: m
491493
//
492494
optional double wheel_radius = 4;
493495

494-
// Radius of the rim measured from the center to the outer, visible part of the rim.
496+
// Median radius of the rim measured from the center to the outer, visible part of the rim.
495497
//
496498
// Unit: m
497499
//
498500
optional double rim_radius = 5;
501+
502+
// Median width of the tire.
503+
//
504+
// Unit: m
505+
//
506+
optional double width = 6;
499507

500508
// Orientation of the wheel.
501509
//
502510
// The reference system is the vehicle frame (center of bounding box).
503511
// Right-handed, x-axis shows into driving direction "forward".
504512
// Rough Approximation: The yaw-value shows the steering angle.
505513
//
506-
optional Orientation3d orientation = 6;
514+
optional Orientation3d orientation = 7;
507515

508516
// Rotation of the wheel around the axle.
517+
// The wheel frame is the reference system.
509518
//
510519
// Unit: Rad/s.
511-
// Counterclockwise is positive, clockwise negative.
512-
// The reference point / view perspective is from the mid of the axle.
513-
// If there is just one wheel centered in the mid of the axle (e.g. bicycle),
514-
// the wheel is treated as a right wheel.
515520
//
516-
optional double rotation_rate = 7;
521+
// Regarding positive or negative values, the right hand rule can be used around
522+
// the y-axis of the vehicle frame (helpful: perspective from the mid of the axis).
523+
// Clockwise is positive, counterclockwise negative.
524+
// If there is just one wheel centered in the mid of the vehicle frame/axle (e.g. bicycle),
525+
// the wheel is treated as it would be on the "right" side.
526+
//
527+
optional double rotation_rate = 8;
528+
529+
// Opaque reference of an associated 3D model of the wheel.
530+
//
531+
// \note It is implementation-specific how model_references are resolved to
532+
// 3d models.
533+
//
534+
optional string model_reference = 9;
517535
}
518536
}
519537

0 commit comments

Comments
 (0)