Skip to content

Commit 7abfadc

Browse files
committed
Implement review comments (#506)
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
1 parent 62aba9a commit 7abfadc

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

doc/architecture/ground_truth.adoc

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
= Ground truth
22

3-
Ground truth describes the simulated environment around all simulated host vehicles in a global coordinate system.
4-
Ground truth provides an exact view on the simulated objects in a global coordinate system.
5-
It is based on internally available data and published to external subscribers.
6-
Depending on the external subscriber, ground-truth data may be individually restricted.
7-
8-
//TODO: It looks like we may have two conflicting descriptions here.
9-
// I cannot tell which one is correct or if they are conflicting at all.
10-
// The first sentence is based on the comments in the proto files.
11-
// The second sentence is based on the description on Github pages.
3+
Ground truth describes the simulated environment around all simulated objects in the global coordinate system.
4+
It is based on data available to the simulation environment and published to external subscribers.
5+
Depending on the external subscriber, ground-truth data may be individually restricted to reduce the data to be exchanged.

doc/architecture/sensor_data.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
= Sensor data
22

33
Sensor data imitates the output of real sensors.
4-
It is generated from ground-truth data, feature data or from sensor data.
4+
It is generated from ground-truth data, sensor-view data, feature data or from sensor data.
55
All information regarding the environment is given with respect to the virtual sensor coordinate system, except for feature data, which is given with respect to the physical sensor coordinate system.
6-
Sensor data can be used as input of an automated driving function, a sensor model simulating limited perception, or a sensor fusion model.
6+
Sensor data can be used as input for an automated driving function, a sensor model simulating limited perception, or a sensor fusion model.

doc/architecture/sensor_view.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ Sensor view imitates the input of sensors.
44
Sensor-view data is derived from ground-truth data.
55
All information regarding the environment is given with respect to the virtual sensor coordinate system, with two exceptions:
66

7-
* Individual physical technology-specific data, given with respect to the physical sensor coordinate system specified in the corresponding physical sensor’s mounting position
8-
* Ground truth data, given in global coordinates.
7+
* Physical technology-specific data, given with respect to the physical sensor coordinate system specified in the corresponding physical sensor’s mounting position.
8+
* Ground-truth data, given in the global coordinate system.

0 commit comments

Comments
 (0)