Skip to content

Feature/fix share options modal #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-mathevet wants to merge 2 commits into
base: staging
Choose a base branch
from
+13 −10
Open

Feature/fix share options modal #2238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f67bd5
Use create-portal function for modals
Aug 13, 2026
5cf0dda
Adjust share options modal sizes for translations
Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/OpenSign/src/primitives/ModalUi.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useEffect, useRef } from "react";
import { useTranslation } from "react-i18next";
import { createPortal } from "react-dom";
import "../styles/signature.css";
import Loader from "./Loader";
import Tooltip from "./Tooltip";
Expand Down Expand Up @@ -49,7 +50,7 @@ const ModalUi = ({
};
}, [isOpen, position]);

return (
return createPortal(
<>
{isOpen && (
<dialog
Expand Down Expand Up @@ -95,7 +96,8 @@ const ModalUi = ({
</div>
</dialog>
)}
</>
</>,
document.body
);
};

Expand Down
17 changes: 9 additions & 8 deletions apps/OpenSign/src/primitives/ShareButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,14 @@ export default function ShareButton({ title, text, url, className, children }) {
</>
}
handleClose={() => setPopupOpen(false)}
reduceWidth="md:min-w-[650px]"
>
{error && <p style={{ color: "red" }}>Error: {error.message}</p>}
<div className="grid grid-cols-1 md:grid-cols-2 justify-items-start text-lg p-[20px]">
<div className="flex flex-wrap justify-center text-lg p-[20px]">
{/* Copy Link */}
<button
onClick={() => navigator.clipboard.writeText(url)}
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[190px]"
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[270px]"
>
<i className="fa-solid fa-clipboard fa-lg"></i> Copy to clipboard
</button>
Expand All @@ -92,7 +93,7 @@ export default function ShareButton({ title, text, url, className, children }) {
"noopener"
)
}
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[190px]"
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[270px]"
>
<i className="fa-brands fa-square-x-twitter fa-lg"></i> Share on
Twitter
Expand All @@ -107,7 +108,7 @@ export default function ShareButton({ title, text, url, className, children }) {
"noopener"
)
}
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[190px]"
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[270px]"
>
<i className="fa-brands fa-square-facebook fa-lg"></i> Share on
Facebook
Expand All @@ -122,7 +123,7 @@ export default function ShareButton({ title, text, url, className, children }) {
"noopener"
)
}
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[190px]"
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[270px]"
>
<i className="fa-brands fa-square-whatsapp fa-lg"></i> Share on
WhatsApp
Expand All @@ -137,7 +138,7 @@ export default function ShareButton({ title, text, url, className, children }) {
"noopener"
)
}
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[190px]"
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[270px]"
>
<i className="fa-solid fa-envelope fa-lg"></i> Share via Gmail
</button>
Expand All @@ -151,7 +152,7 @@ export default function ShareButton({ title, text, url, className, children }) {
"noopener"
)
}
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[190px]"
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[270px]"
>
<i className="fa-brands fa-microsoft fa-lg"></i> Share on Teams
</button>
Expand All @@ -165,7 +166,7 @@ export default function ShareButton({ title, text, url, className, children }) {
"noopener"
)
}
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[190px]"
className="m-2 op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm w-[270px]"
>
<i className="fa-solid fa-envelope-open-text fa-lg"></i> Share via
Outlook
Expand Down