Repository navigation
Conversation
Draw caption outlines before filling glyphs so the stroke does not obscure the text interior. Add a pixel-based regression test that fails with the original rendering order. Fixes OpenShot#1033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1033.
The Caption effect previously rendered the text stroke and fill in a single
QPainter::drawPath()operation. With thicker strokes, the outline extended into the glyph interior, partially obscuring the caption text.This change draws the stroke first, followed by the fill, ensuring that the caption's interior remains unobstructed.
Changes
Qt::NoBrush.Qt::NoPen.Testing
Environment: Ubuntu, GCC 15, Qt 5.
git diff --check: PASSNegative-control verification
The regression test was also executed against the original rendering implementation.
This confirms that the regression test detects the original rendering defect and passes with the correction.
Scope
The changes are limited to:
src/effects/Caption.cpptests/Caption.cppNo changes to unrelated effects or encoding functionality.