Skip to content

Conversation

@kneckinator
Copy link
Contributor

@kneckinator kneckinator commented May 12, 2025

Why is this change needed?

Makes the code easier to read and reduces noise in our code-quality scanners.

Extras

Add some tests to improve test coverage. See commit history.

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 74.59016% with 31 lines in your changes missing coverage. Please review.

Project coverage is 76.07%. Comparing base (b5f51b9) to head (81b4f09).

Files with missing lines Patch % Lines
spp_api/controllers/pinguin.py 0.00% 15 Missing ⚠️
spp_starter/wizards/spp_starter.py 77.77% 2 Missing and 6 partials ⚠️
...armer_registry_demo/models/generate_farmer_data.py 20.00% 4 Missing ⚠️
spp_starter/tests/test_spp_starter.py 85.71% 3 Missing ⚠️
spp_mis_demo/models/generate_group.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #806      +/-   ##
==========================================
+ Coverage   75.68%   76.07%   +0.38%     
==========================================
  Files         764      765       +1     
  Lines       20218    20280      +62     
  Branches     2501     2502       +1     
==========================================
+ Hits        15302    15428     +126     
+ Misses       4381     4309      -72     
- Partials      535      543       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@kneckinator kneckinator merged commit 1684502 into 17.0 May 14, 2025
9 of 10 checks passed
@kneckinator kneckinator deleted the ken/code_cleanup branch May 14, 2025 01:47
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants