Skip to content

feat(change_request): redesign Create Group & Add Member CRs + review-page fixes (#876 #871)#242

Open
emjay0921 wants to merge 32 commits into
19.0from
feat/876-create-group-cr-redesign
Open

feat(change_request): redesign Create Group & Add Member CRs + review-page fixes (#876 #871)#242
emjay0921 wants to merge 32 commits into
19.0from
feat/876-create-group-cr-redesign

fix(change_request_v2): Change HoH follows New Role literally (#873)

8fa64f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 23, 2026 in 1s

71.57% (+0.06%) compared to c660896

View this Pull Request on Codecov

71.57% (+0.06%) compared to c660896

Details

Codecov Report

❌ Patch coverage is 85.99269% with 115 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.57%. Comparing base (c660896) to head (8fa64f4).
⚠️ Report is 106 commits behind head on 19.0.

Files with missing lines Patch % Lines
spp_change_request_v2/details/create_group.py 85.97% 23 Missing ⚠️
spp_change_request_v2/details/add_member.py 73.07% 14 Missing ⚠️
...pp_change_request_v2/strategies/split_household.py 83.95% 13 Missing ⚠️
spp_change_request_v2/wizards/create_wizard.py 7.14% 13 Missing ⚠️
spp_mis_demo_v2/models/mis_demo_generator.py 76.92% 12 Missing ⚠️
spp_change_request_v2/models/change_request.py 82.81% 11 Missing ⚠️
spp_change_request_v2/details/split_household.py 83.63% 9 Missing ⚠️
spp_change_request_v2/strategies/create_group.py 94.01% 7 Missing ⚠️
spp_change_request_v2/strategies/change_hoh.py 84.84% 5 Missing ⚠️
...pp_change_request_v2/models/change_request_type.py 82.35% 3 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0     #242      +/-   ##
==========================================
+ Coverage   71.50%   71.57%   +0.06%     
==========================================
  Files        1001     1004       +3     
  Lines       58626    60003    +1377     
==========================================
+ Hits        41921    42947    +1026     
- Misses      16705    17056     +351
Files with missing lines Coverage Δ
spp_change_request_v2/__manifest__.py 0.00% <ø> (ø)
spp_change_request_v2/details/remove_member.py 48.27% <ø> (-3.34%) ⬇️
spp_change_request_v2/strategies/remove_member.py 90.32% <100.00%> (ø)
spp_change_request_v2/wizards/__init__.py 100.00% <100.00%> (ø)
spp_change_request_v2/details/change_hoh.py 98.30% <97.82%> (+34.01%) ⬆️
spp_change_request_v2/strategies/add_member.py 92.59% <93.75%> (+1.16%) ⬆️
...e_request_v2/wizards/create_group_member_wizard.py 97.77% <97.77%> (ø)
...pp_change_request_v2/models/change_request_type.py 69.00% <82.35%> (+1.47%) ⬆️
spp_change_request_v2/strategies/change_hoh.py 85.96% <84.84%> (-3.51%) ⬇️
spp_change_request_v2/strategies/create_group.py 93.38% <94.01%> (-0.74%) ⬇️
... and 7 more

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov