cachedb_redis: add ASK redirect handling for cluster resharding#3852
Open
dondetir wants to merge 1 commit intoOpenSIPS:masterfrom
Open
cachedb_redis: add ASK redirect handling for cluster resharding#3852dondetir wants to merge 1 commit intoOpenSIPS:masterfrom
dondetir wants to merge 1 commit intoOpenSIPS:masterfrom
Conversation
Member
|
This appears to be a partial duplicate of #3815 |
Author
|
Thanks for pointing that out @NormB. You're right — the hash slot fix ( The unique part of this PR is the ASK redirect handling (detection + Happy to rebase and drop the hash slot change once #3815 merges, keeping only the ASK redirect logic. Or if you'd prefer, I can split this into a separate ASK-only PR right now. Let me know what works best. |
This was referenced Mar 30, 2026
Add support for Redis ASK redirects during cluster resharding. When a slot is being migrated between nodes, Redis returns an ASK response instead of MOVED. Unlike MOVED (permanent redirect), ASK is a one-time redirect that requires sending the ASKING command to the target node before retrying the original query. The implementation: - Detects ASK responses alongside existing MOVED handling - Sends ASKING command to the target node before retrying - Reuses the MOVED redirect infrastructure (endpoint lookup, reconnection, retry logic) Also refactor parse_moved_reply() into parse_redirect_reply() that accepts the prefix as a parameter, with inline wrappers parse_moved_reply() and parse_ask_reply() for backward compatibility. Partially addresses OpenSIPS#2811
dondetir
force-pushed
the
feature/redis-cluster-ask-topology
branch
from
f3ee6c8 to
fc8a736
Compare
dondetir
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for Redis ASK redirects during cluster resharding, completing the cluster redirect handling started in PR #3639.
Background
When a Redis cluster is resharding (migrating slots between nodes), the source node returns an
ASKresponse instead ofMOVED. The key difference:ASKINGto the target node before retryingWithout ASK handling, queries during resharding operations fail with unhandled error responses.
Implementation
ASKINGcommand to the target node before retrying the original queryparse_moved_reply()intoparse_redirect_reply()that accepts the prefix as a parameter, with inline wrappersparse_moved_reply()andparse_ask_reply()for backward compatibilityNote on hash slot fix
The original version of this PR also included a hash slot calculation fix. That has been removed per @NormB's feedback, as his PR #3815 addresses this more comprehensively (including hash tag support). This PR now contains only the ASK redirect handling.
Testing
parse_redirect_reply()refactor passes integration tests with live slot migrations across a 3-node clusterPartially addresses #2811