Repository navigation
fix: pin the tools image Node base to 24.22.2-bookworm-slim by digest - #5
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
LukasParke
marked this pull request as ready for review
November 6, 2026 15:48
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
alexb-openrouter
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the Node stages of
images/tools/Dockerfileto an exact, digest-pinned base instead of the floatingnode:24-bookworm-slimtag:Node 24.22.2 is the current 24.x release and includes the fixes from the Node.js security release of October 21, 2026 (CVE-2026-111497 and the TLS and DNS hostname issues). With a floating tag, the Node patch inside the image depends on when the image was last built. With the digest pin, every build of a given source tree resolves the same base, and a Node patch bump shows up as a reviewable diff.
The 150
tasks/*/environment/docker-compose.yamlfiles change because the tools image tag is a content hash of the image sources (crates/scenario/src/images.rs). The new tag istool-bench-tools:521c33382f76f96a. The image publish workflow builds and pushes it on the next push tomain, which is also the rebuild that replaces any tools image built from an older24.xbase.Verification
Builds from this branch with
docker buildx build --pull --platform linux/amd64 -f images/tools/Dockerfile ., before and after the change:node -vprintsv24.22.2, Debian 12 (bookworm).node -vprintsv24.22.2, Debian 12 (bookworm).process.versionsis identical to the baseline (OpenSSL 3.5.9, brotli 1.2.0, c-ares 1.34.9), and the same 15 binaries in/opt/binand 36 npm server binaries are present.cargo test --workspace --locked,cargo clippy --workspace --all-targets --locked -- -D warnings, andtaskgen --checkpass.Risk: low. Same major, same Debian base, same image variant. A floating
node:24-bookworm-slimbuild from before the pin is the rollback target, and it carries whichever Node patch was current at that build.Follow-up: the next Node.js security release moves this pin again, so bump the tag and digest together when it lands.