Skip to content

Improve parser fidelity for empty text shapes and OOXML defaults - #12

Merged
RealSid08 merged 2 commits into
mainfrom
feat/fidelity-text-bodypr-spacing
Mar 29, 2026
Merged

RealSid08 merged 2 commits into
mainfrom
feat/fidelity-text-bodypr-spacing

Conversation

@RealSid08

Copy link
Copy Markdown
Member

Summary

  • apply OOXML default text body insets when bodyPr omits inset attributes
  • improve empty txBody handling so styled, large placeholders can be parsed as visual shapes
  • add HSL-based luminance transform support for scheme colors and scoped alpha handling for shape fill/stroke colors
  • preserve custom geometry path command order and parse path metadata into shape model
  • update fixture snapshots and tests to lock in new parser behavior

Validation

  • pnpm run fixtures:generate
  • pnpm run verify
  • pnpm run pack:check
  • VISUAL_CASES=slop-sample pnpm run test:visual

Notes

  • focused visual validation keeps slop-sample slide 11 around diffRatio 0.1018 while avoiding broader regressions from more aggressive custom-geometry rendering experiments

@RealSid08 RealSid08 added the release:patch Publish a patch release on merge label Mar 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Visual PR Diff

Compared 15 visual cases against the latest successful main visual artifact and found 10 changed cases.

Renderer Change Ranking

Case Max Diff Mean Diff Top Changed Slides
slop-sample 0.8212 0.1139 11 (0.8212), 8 (0.4539), 10 (0.0636), 9 (0.0130), 4 (0.0089)
complex-sanitized 0.4743 0.1209 8 (0.4743), 4 (0.0092), 1 (0.0000), 5 (0.0000)
theme-luminance 0.0933 0.0933 1 (0.0933)
diagram-fallback 0.0650 0.0347 10 (0.0650), 2 (0.0043)
bullets-numbering 0.0106 0.0106 1 (0.0106)
unsupported-chart 0.0065 0.0065 1 (0.0065)
theme-colors 0.0059 0.0059 1 (0.0059)
text-layout 0.0054 0.0054 1 (0.0054)
image-placement 0.0052 0.0052 1 (0.0052)
image-cropping 0.0049 0.0049 1 (0.0049)

Most Regressed Vs Office Reference

Case Mean Delta Max Delta Worst Slide Delta
diagram-fallback +0.0031 +0.0022 10 (+0.0040)
nested-groups +0.0001 +0.0001 1 (+0.0001)

Most Improved Vs Office Reference

Case Mean Delta Max Delta Best Slide Delta
complex-sanitized -0.0952 0.0000 8 (-0.3795)
slop-sample -0.0927 -0.0277 11 (-0.7275)
bullets-numbering -0.0012 -0.0012 1 (-0.0012)
unsupported-chart -0.0009 -0.0009 1 (-0.0009)
image-placement -0.0006 -0.0006 1 (-0.0006)

Preview Slides

slop-sample slide 11

MainPRDiff
Main baseline slop-sample slide 11PR current slop-sample slide 11Diff slop-sample slide 11

complex-sanitized slide 8

MainPRDiff
Main baseline complex-sanitized slide 8PR current complex-sanitized slide 8Diff complex-sanitized slide 8

theme-luminance slide 1

MainPRDiff
Main baseline theme-luminance slide 1PR current theme-luminance slide 1Diff theme-luminance slide 1

Artifacts include HTML side-by-side reports under visual-regression-artifacts and visual-pr-comparison.

github-actions Bot added a commit that referenced this pull request Mar 29, 2026
@RealSid08
RealSid08 merged commit eb6ebef into main Mar 29, 2026
7 checks passed
@RealSid08
RealSid08 deleted the feat/fidelity-text-bodypr-spacing branch March 29, 2026 12:56
github-actions Bot added a commit that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:patch Publish a patch release on merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant