Skip to content

Retain managed trainer runtime metadata in the GPU image #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bradhilton wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Retain managed trainer runtime metadata in the GPU image #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/art-gpu.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ RUN if ! getent group messagebus >/dev/null; then groupadd -r messagebus; fi \

COPY --from=builder --chown=sky:sky /opt/uv-cache /opt/uv-cache
COPY --from=builder --chown=sky:sky /opt/uv-python /opt/uv-python
COPY --from=builder --chown=sky:sky /opt/src/art/megatron_runtime/pyproject.toml /opt/src/art/megatron_runtime/uv.lock /opt/src/art/megatron_runtime/

USER sky
WORKDIR /home/sky
Expand Down
20 changes: 20 additions & 0 deletions tests/unit/test_gpu_image_build_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,23 @@ def test_gpu_image_build_context_copies_every_local_docker_source() -> None:
continue
for source in shlex.split(line)[1:-1]:
assert f"${{repo_root}}/{source}" in build_script


def test_gpu_image_retains_only_managed_megatron_project_metadata() -> None:
dockerfile = (ROOT / "docker/art-gpu.Dockerfile").read_text()
final_stage = dockerfile.rsplit("\nFROM ", 1)[1]
copies = [
shlex.split(line)
for line in final_stage.splitlines()
if line.startswith("COPY ") and "/opt/src/art" in line
]
assert copies == [
[
"COPY",
"--from=builder",
"--chown=sky:sky",
"/opt/src/art/megatron_runtime/pyproject.toml",
"/opt/src/art/megatron_runtime/uv.lock",
"/opt/src/art/megatron_runtime/",
]
]
Loading