Preserve first-captured MoE routes for extending prompts - #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
vLLM retains routed experts for full prefix-cache blocks, but an unaligned suffix can be recomputed when a later request extends the prompt. Those tokens may move from decode execution to prefill execution and legitimately select different experts. A request that crosses an in-flight policy update can also recompute prompt positions under the new policy.
The earlier capture remains the replay authority for already-recorded tokens. Rejecting a later disagreement therefore aborts a valid trajectory instead of preserving its original routes.
Validation