Support W&B 0.28 and vLLM 0.24 DSV4 LoRA#754
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lora_managerattribute required by vLLM 0.24's runtime-checkable LoRA protocol for DeepSeek V4Why
Caladan's live DeepSeek-V4-Flash qualification exposed two integration gaps. ART's backend W&B pin conflicted with Caladan's validated W&B 0.28 dependency, and vLLM 0.24 rejected the patched DSV4 model after weight loading because the structural LoRA protocol now requires
lora_manager.The Click 8.2 override is required because W&B 0.28 requires Click 8.2 or newer while ART's current SkyPilot development dependency still declares an older upper bound. ART's existing CLI smoke test remains functional; this follows the same override already used by Caladan.
Validation
uv lock --checkpassedFull ART type checking still reports existing CPU-environment Megatron/Torch and missing optional
einopsdiagnostics; none originate in this diff.