Skip to content

Validate yaml returns different results#170

Open
CIGbalance wants to merge 1 commit intomainfrom
fix/merge_validate
Open

Validate yaml returns different results#170
CIGbalance wants to merge 1 commit intomainfrom
fix/merge_validate

Conversation

@CIGbalance
Copy link
Copy Markdown
Collaborator

@CIGbalance CIGbalance commented Apr 21, 2026

This is actually not needed any more, the update existing data also validates already

Copilot AI review requested due to automatic review settings April 21, 2026 15:53
@CIGbalance CIGbalance requested a review from kvdblom April 21, 2026 15:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes merge_yaml.py’s post-merge validation step by removing an incorrect call pattern to validate_yaml(...) (which is implemented as a CLI-style function that exits the process rather than returning data), avoiding inconsistent/incorrect “return value” behavior during merges.

Changes:

  • Removed the final “validate resulting data” block after writing the merged YAML.
  • Relies on the existing in-memory validate_data(...) check performed before writing merged output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants