Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes merge_yaml.py’s post-merge validation step by removing an incorrect call pattern to validate_yaml(...) (which is implemented as a CLI-style function that exits the process rather than returning data), avoiding inconsistent/incorrect “return value” behavior during merges.
Changes:
- Removed the final “validate resulting data” block after writing the merged YAML.
- Relies on the existing in-memory
validate_data(...)check performed before writing merged output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually not needed any more, the update existing data also validates already