Skip to content

M #-: Set permissions for /var/run/one/vhost-socks/#206

Open
sk4zuzu wants to merge 1 commit intomasterfrom
handle-dpdk-vhost
Open

M #-: Set permissions for /var/run/one/vhost-socks/#206
sk4zuzu wants to merge 1 commit intomasterfrom
handle-dpdk-vhost

Conversation

@sk4zuzu
Copy link
Copy Markdown
Collaborator

@sk4zuzu sk4zuzu commented Apr 20, 2026

No description provided.

@sk4zuzu sk4zuzu requested review from dann1, rsmontero and tinova April 20, 2026 16:13
@sk4zuzu
Copy link
Copy Markdown
Collaborator Author

sk4zuzu commented Apr 20, 2026

@dann1 I researched the vhost socket selinux problem and I believe choosing /var/lib/one/vhost-sockets/ is a mistake. After briefly discussing with @rsmontero I created this simpler PR that is using /var/run/one/vhost-socks/ directory instead.

I believe there are several benefits:

  1. we need custom selinux policy anyways, but it seems to be simpler
  2. we dont have to deal with the fact that /var/lib/one is a "home directory", so this will be much easier for users that deploy nebula without one-deploy, and also most users will be expecting sockets to be in /var/run/ anyways as it seems to be "semantically" correct
  3. we already have /var/run/one/ssh-socks/ so we would have /var/run/one/vhost-socks/ 👍😍🧦

In 7.2.1 we'd adjust the VNET drivers. Let's discuss this here. 😇

@dann1
Copy link
Copy Markdown
Collaborator

dann1 commented Apr 20, 2026

Makes sense. I'll try out the whole role now with the adjusted dir on ovs vnet driver and kvm domain xml logic. There is also logic to create the socket dir with permissions in the 7.2 packages install script logic.

Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
@sk4zuzu sk4zuzu force-pushed the handle-dpdk-vhost branch from 909677e to 6b77630 Compare April 20, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants