Add support for MaterialX data types#26
Merged
Merged
Conversation
added 2 commits
July 10, 2026 16:50
MOONRAY-6063 Add map shader support for datatypes which materialx map shaders can produce Signed-off-by: Jon Lanz <jon.lanz@dreamworks.com>
MOONRAY-6063 add back in a strange double include until we can figure out why this is needed Signed-off-by: Jon Lanz <jon.lanz@dreamworks.com>
|
This was referenced Jul 11, 2026
dmccann-dwa
reviewed
Jul 13, 2026
dmccann-dwa
approved these changes
Jul 13, 2026
dmccann-dwa
left a comment
dmccann-dwa
left a comment
Contributor
There was a problem hiding this comment.
LGTM
There is a scary TODO and some whitespace problems with eval____ functions, however.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOONRAY-6063 fix use of MAP_GET_ISPC_PTR to NORMALMAP_GET_ISPC_PTR in normalmap shaders
Signed-off-by: Jon Lanz jon.lanz@dreamworks.com
Compatibility:
minor
Issues/Tickets:
MOONRAY-6063
Release notes comment:
Add support for MaterialX data types
Comments for the reviewer:
This represents a significant amount of work and paves the way for adding MaterialX pattern generators (aka Map shaders).
See also:
OpenMoonRay/scene_rdl2#18
#26
OpenMoonRay/moonshine#6
Look or scene setup change:
Special notes for production:
Attention/Reviewers:
AI Assisted Development:
Checklist: