You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Change OPENBLAS_API back to BLASFUNC when generating f77blas.h - #6116
Thanks for the quick fix. I checked the installed Make header at e8b92a8 with the include-only test from #6112 (#include <f77blas.h>, GCC 15.2), and also exercised its CMake header-generation change:
Make (x86-64, TARGET=HASWELL DYNAMIC_ARCH=0 NO_FORTRAN=1, then make install): one error remains, from the direct OPENBLAS_EXPORT on openblas_set_num_threads_:
f77blas.h:52:16: error: expected ';' before 'void'
Stripping OPENBLAS_EXPORT as the cblas.h recipe already does gives a header that compiles cleanly. In Makefile.install, that would be sed -e 's/OPENBLAS_API/BLASFUNC/g' -e 's/OPENBLAS_EXPORT //'.
CMake header generation (aarch64, CMake 4.2.3, GCC/gfortran 15.2; configure only, using an existing guest source tree overlaid with this PR's CMakeLists.txt and develop's common_interface.h): the unquoted ${COMMON_INTERFACE_H_CONTENTS} in the new string(REPLACE ...) splits the header at semicolons. The generated header has zero of the source's 468 semicolons and fails to compile. Quoting the input and stripping OPENBLAS_EXPORT preserves all 468 and passes the include-only test:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6112