Repository navigation
Fix build on the GNU Hurd. - #6111
Merged
Merged
Conversation
SYS_* system call numbers are not defined on the Hurd system. Three of them, SYS_mbind, SYS_set_mempolicy, and SYS_gettid, are used in "common_linux.h". The first two are about setting NUMA (Non‐Uniform Memory Access) policy. NUMA is not supported by the Hurd for now. The third one refers to the Linux specific model of threads. Therefore it is safe to simply disable these syscalls on the GNU Hurd.
Collaborator
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
SYS_* system call numbers are not defined on the Hurd system. Three of them, SYS_mbind, SYS_set_mempolicy, and SYS_gettid, are used in "common_linux.h". The first two are about setting NUMA (Non‐Uniform Memory Access) policy. NUMA is not supported by the Hurd for now. The third one refers to the Linux specific model of threads. Therefore it is safe to simply disable these syscalls on the GNU Hurd.
OpenBLAS with the proposed patch was successfully build on the GNU Guix Hurd platforms
(both 32 and 64-bit versions), and merged into the GNU Guix, see https://codeberg.org/guix/guix/pulls/11496.