majestic-streamer: goke does speaker output too, and spell hisilicon right - #486
Open
openipc-ai wants to merge 2 commits into
Open
majestic-streamer: goke does speaker output too, and spell hisilicon right#486openipc-ai wants to merge 2 commits into
openipc-ai wants to merge 2 commits into
Conversation
The talkback section listed the platforms with working speaker output as HiSilicon, Ingenic, Sigmastar, Allwinner, Rockchip and Xiongmai, omitting Goke. That omission sent the reporter of OpenIPC/firmware#2183 hunting for a third-party baresip module to get audio onto a gk7205v200 speaker, when majestic's RTSP back-channel already covers it. Goke SoCs are HiSilicon-derived and share the audio path, so pair them the way the motion-detect line above already does.
PR Summary by QodoDocument Goke support for Majestic talkback speaker output
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab) |
The motion-detect line read "Hisilion/Goke". This is the only occurrence of that misspelling in the wiki; the casing variant "Hisilicon" is a separate and much wider inconsistency, and several of its occurrences are verbatim kernel output or package paths, so leave those alone.
openipc-ai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two corrections to platform names in
en/majestic-streamer.md.1. Goke was missing from the speaker-output platform list. The "Two-way audio (talkback)" section listed the platforms with working speaker output as HiSilicon, Ingenic, Sigmastar, Allwinner, Rockchip and Xiongmai. Goke speaker output is supported, so the omission is a documentation bug.
2. "Hisilion" typo. The motion-detection line read
Hisilion/Goke.Why it matters
The first one has a real cost. The reporter of OpenIPC/firmware#2183 wanted to play audio from a go2rtc server on a gk7205v200 speaker and went looking for third-party baresip modules (
goke.so,audio_source rtspausrc) to do it — modules that exist in no OpenIPC repo and in no upstream baresip release. Majestic'srtsp.backchannelalready covers that use case, but the docs read as though Goke was not among the platforms it works on.Fix
en/majestic-streamer.md:313—HiSilicon→HiSilicon/Goke, matching the pairing the motion-detect line at:118anden/howto-frigate-integration.md:136already use.en/majestic-streamer.md:118—Hisilion→HiSilicon.Verification
en/majestic-streamer.md:313is the only place inen/andru/that enumerates the speaker-output platforms — checked by grepping for the neighbouring platform names; no other copy of the list exists.Hisilionoccurs exactly once acrossen/andru/. The separate lowercase-s variantHisiliconis far more widespread (19 occurrences) and is deliberately left alone here: several are verbatim kernel log output (en/device-chacon-ipcam-ri01.md) or package paths in URLs, so that cleanup needs its own pass.Gokeis already an established term in the wiki (en/help-uboot.md:360), so no spell-check dictionary change is needed.