Repository navigation
Share page: the camera's Live page can ask for the whole screen - #460
Merged
Merged
Conversation
An iPhone has no fullscreen for a page element, so the camera's Live page offers Fill screen instead: its navbar and banners step aside. Inside a share the share page's own bar has to as well, or the picture still starts under it. window.__share.fill(on) toggles that bar; a WebUI that does not call it is unchanged.
PR Summary by QodoLet shared camera pages hide the share bar in Fill screen mode
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can tweak Display settings with a live preview to see your comment before it ships |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An iPhone has no fullscreen for a page element, so the camera's Live page
offers Fill screen instead: its navbar and banners step aside. Inside a share
the share page's own bar has to as well, or the picture still starts under
it. window.__share.fill(on) toggles that bar; a WebUI that does not call it
is unchanged.