Skip to content

Share page: the camera's Live page can ask for the whole screen - #460

Merged
widgetii merged 1 commit into
masterfrom
share-fill-screen
Oct 11, 2026
Merged

widgetii merged 1 commit into
masterfrom
share-fill-screen

Conversation

@widgetii

Copy link
Copy Markdown
Member

An iPhone has no fullscreen for a page element, so the camera's Live page
offers Fill screen instead: its navbar and banners step aside. Inside a share
the share page's own bar has to as well, or the picture still starts under
it. window.__share.fill(on) toggles that bar; a WebUI that does not call it
is unchanged.

An iPhone has no fullscreen for a page element, so the camera's Live page
offers Fill screen instead: its navbar and banners step aside. Inside a share
the share page's own bar has to as well, or the picture still starts under
it. window.__share.fill(on) toggles that bar; a WebUI that does not call it
is unchanged.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Let shared camera pages hide the share bar in Fill screen mode

✨ Enhancement 🕐 Less than 10 minutes

Grey Divider

AI Description

• Expose a share-page API so the camera’s Live page can request Fill screen on iPhone.
• Hide the share bar while requested, giving the picture its space; other WebUIs remain unchanged.
Diagram

graph TD
  A["Camera Live page"] --> B["Share fill API"] --> C{"Fill requested?"}
  C -->|Yes| D["Hide share bar"] --> F["Picture gains space"]
  C -->|No| E["Show share bar"]
Loading
High-Level Assessment

The opt-in body class is a suitable boundary between the camera page’s request and the share shell’s layout. Relying solely on browser fullscreen would not address the stated iPhone limitation, while changing the bar globally would affect WebUIs that never request Fill screen.

Files changed (2) +5 / -0

Enhancement (2) +5 / -0
index.htmlHide the share header when Fill screen is active +2/-0

Hide the share header when Fill screen is active

• Adds a CSS rule that removes the share-page header from layout when the body has the share-fill class. The default header layout is unchanged.

service/internal/sharerelay/static/index.html

shell.jsExpose a fill toggle through the share bridge +3/-0

Expose a fill toggle through the share bridge

• Adds window.__share.fill(on) to toggle the share-fill body class. Camera pages can request or end the share shell’s Fill screen layout.

service/internal/sharerelay/static/shell.js

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can tweak Display settings with a live preview to see your comment before it ships

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@widgetii
widgetii merged commit f005088 into master Oct 11, 2026
2 checks passed
@widgetii
widgetii deleted the share-fill-screen branch October 11, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant