Skip to content

hisilicon-opensdk: bump to 7f3697d, SP2305 exposure written every frame - #2563

Merged
openipc-ai merged 1 commit into
masterfrom
hisilicon-opensdk-sp2305-exposure
Oct 9, 2026
Merged

openipc-ai merged 1 commit into
masterfrom
hisilicon-opensdk-sp2305-exposure

Conversation

@openipc-ai

Copy link
Copy Markdown
Collaborator

What

Bumps hisilicon-opensdk from 4e5359b to 7f3697d, bringing in OpenIPC/openhisilicon#255.

Why

The SP2305/OV2735 sensor driver (hi3516ev200 family, gk7205v200 family) wrote the exposure registers only when auto-exposure changed its value. A corrupted value therefore stayed in the sensor.

Running a sensor probe on a streaming camera corrupted it: ipctool -s or ipcinfo --short-sensor wrote 0xF1 into the exposure high byte. In a bright scene the picture went white and stayed white until the streamer restarted. This is the random white-out in OpenIPC/majestic#295.

Scope

The range has one other commit, #254. It only changes the NPU test tools (xmedia_npu/test), which this package does not build. The only shipped file that changes is libsns_sp2305.so.

Tested

On an hi3516ev300 with an SP2305/OV2735, with the driver from #255:

  • the exposure register corrupted to 0xF1: picture recovered within 0.3 s;
  • ipctool -s run while streaming: picture recovered within 3 s;
  • the old driver stayed white in both cases.

Brings in OpenIPC/openhisilicon#255. The SP2305/OV2735 driver wrote
its exposure only when auto-exposure changed it, so a corrupted value in
the sensor stayed until the scene changed. A sensor probe at its address
(ipctool -s, ipcinfo --short-sensor) corrupted it, leaving a white
picture until the streamer restarted (OpenIPC/majestic#295). The probe
itself is fixed in OpenIPC/ipctool#238, which this package picks up at
HEAD.

The other commit in the range (#254) only touches the NPU test tools,
which are not built here.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Bump OpenHisilicon to restore SP2305 exposure each frame

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Pins OpenHisilicon to 7f3697d, bringing in the SP2305/OV2735 exposure fix.
• Rewrites exposure each frame outside pixel calibration, preventing persistent white video after
 sensor probes.
Diagram

graph TD
  P["OpenSDK package"] -->|fetches pinned revision| U["OpenHisilicon source"] -->|builds| D["SP2305 driver"] -->|rewrites exposure| S["SP2305 sensor"]
Loading
High-Level Assessment

Pinning the upstream fix is preferable to carrying a local driver patch: it delivers the corrected sensor library through the existing build and install path without maintaining a fork. The additional upstream NPU test-tool change is not built by this package.

Files changed (1) +1 / -1

Other (1) +1 / -1
hisilicon-opensdk.mkPin OpenHisilicon to revision 7f3697d +1/-1

Pin OpenHisilicon to revision 7f3697d

• Changes the fetched upstream revision from 4e5359b to 7f3697d. The new revision includes the SP2305/OV2735 driver fix that rewrites exposure every frame outside pixel calibration; the package's build and install rules are unchanged.

general/package/hisilicon-opensdk/hisilicon-opensdk.mk

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@openipc-ai
openipc-ai merged commit 3449f14 into master Oct 9, 2026
76 of 77 checks passed
@openipc-ai
openipc-ai deleted the hisilicon-opensdk-sp2305-exposure branch October 9, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant