Repository navigation
rostelecom-ipc8232swc-we: correct the lens's barrel distortion (isp.ldc 200) - #203
Merged
Merged
Conversation
…dc 200) The board's wide lens bows straight lines outward; the stock firmware corrects it in VI with DistortionRatio 200, crop view, centred (read from its /proc/umap/vi). Set the same in the board's customizer: the lens is the board's, so this is where its number belongs.
widgetii
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
October 14, 2026 13:13
Contributor
|
/review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can switch off images and animations for a plain-text comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The board's wide lens bows straight lines outward: door frames and cabinet sides curve toward the edges of the picture. The stock firmware corrects this. OpenIPC did not.
Change
customizer.shnow setscli -s .isp.ldc 200. That is majestic's VI lens distortion correction, with the same parameters the stock firmware runs on this camera. Read from its/proc/umap/vi,VI CHN LDCV3 INFOshows: Crop, DistortionRatio 200, centre 0/0, MinRatio 0.It lives in the board profile because the lens belongs to the board: other boards with the same SP2305/OV2735 sensor may have a different lens or none.
Cost
isp.blkCnt 6carries that at 25 fps.Requirement:
isp.ldcis in majestic master as of today. The first image built from tonight's majestic nightly onward has it.Hardware tested on
The lab IPC8232SWC-WE (Hi3516EV300, ov2735), running the line above:
/proc/umap/vishowsY Crop 0 200 0 0, identical to the stock-firmware camera, with VI online / VPSS offline.