-
Notifications
You must be signed in to change notification settings - Fork 76
Add Responses API streaming support #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db1963e to
c3f24cd
Compare
c3f24cd to
d149370
Compare
48ea9e3 to
5f86198
Compare
5f86198 to
e31b728
Compare
|
😭 oh my the merge conflict |
c1a2ced to
3983ce4
Compare
784f76f to
28f4a2c
Compare
Coverage Report •
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
28f4a2c to
a341d0e
Compare
|
@OpenHands understand why CI fails ============================================================
|
|
I'm on it! enyst can track my progress at all-hands.dev |
|
Summary of work Why CI failed
What I changed
Pull request to the docs repo
Checklist
Next steps
|
|
[Automatic Post]: It has been a while since there was any activity on this PR. @enyst, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
@OpenHands Merge main branch and fix the conflicts. |
|
Uh oh! There was an unexpected error starting the job :( |
|
[Automatic Post]: It has been a while since there was any activity on this PR. @enyst, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
@OpenHands Read this PR and understand its purpose and approach. Read the readme to know how to build the project. We just merged main, into this branch, and we need to fix the branch. Run pre-commit on all files and fix. |
|
I'm on it! enyst can track my progress at all-hands.dev |
|
[Automatic Post]: It has been a while since there was any activity on this PR. @enyst, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
Co-authored-by: openhands <openhands@all-hands.dev>
|
@OpenHands please merge from main, resolve all the conflicts and make sure pre-commit run --all-files works |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
Resolved merge conflicts by: 1. Keeping streaming-related constants in llm.py 2. Updating make_llm_completion() in utils.py to support streaming callbacks 3. Using the unified make_llm_completion() function in agent.py with streaming support 4. Removed _add_security_risk_prediction property since security_analyzer was removed from AgentBase in main Co-authored-by: openhands <openhands@all-hands.dev>
- Add on_token parameter to all agent step() method signatures - Import ConversationTokenCallbackType where needed - Fix LLM router to pass on_token parameter to underlying LLM - Fix example 24_responses_streaming.py (service_id -> usage_id, visualize -> visualizer) - All pre-commit checks now passing Co-authored-by: openhands <openhands@all-hands.dev>
✅ Task Completed SuccessfullyI've successfully merged the main branch into streaming-responses, resolved all conflicts, and fixed all issues to make pre-commit checks pass. Summary of Changes1. Merge Completed (commit 27f9653)
2. Fixed Type Errors (commit dbbd0cf)
3. Verification
All changes are minimal and directly address the merge conflicts and type errors introduced by the merge. The streaming-responses branch is now up to date with main and ready for review. |
|
@OpenHands please fix the failing actions on PR #808 at branch |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
- Fix circular import between agent/utils.py and conversation modules by using lazy imports - Update test_agent_utils.py to include new streaming parameters (on_token, metadata, extra_body) - All tests now passing Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
✅ All Failing Actions Fixed on PR #808I've successfully fixed all failing CI checks on the Changes Made to agent-sdk Repository:
Changes Made to docs Repository:
CI Status: All Checks Passing ✅All 22/22 checks are now passing:
Commits:
The PR is now ready for review with all CI checks passing! 🎉 |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
|
[Automatic Post]: It has been a while since there was any activity on this PR. @enyst, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
1 similar comment
|
[Automatic Post]: It has been a while since there was any activity on this PR. @enyst, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
[Automatic Post]: I have assigned @neubig as a reviewer based on git blame information. Thanks in advance for the help! |
Summary
Testing
pytest tests/sdk/llm/test_responses_parsing_and_kwargs.pypytest tests/sdk/agent/test_agent_step_responses_gating.pyfix: #450
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:58286ad-pythonRun
All tags pushed for this build
About Multi-Architecture Support
58286ad-python) is a multi-arch manifest supporting both amd64 and arm6458286ad-python-amd64) are also available if needed