chore: green up tsc --noEmit on main#71
Merged
Merged
Conversation
Brings tsc --noEmit to a clean exit so CI can enforce it. Four discrete fixes plus one tsconfig exclusion: - tsconfig: exclude src/packages/openplans-core/src/elements/catalog/. Those files reference non-existent ../shared/* modules (~115 TS errors) and have all index.ts exports commented out, so they are not part of any build output. Full deletion deferred. - Delete src/packages/openplans-core/src/elements/solids/wall-component/ wall-engine.ts. Class was orphan (no importers anywhere) with stub method bodies. Removed the now-empty wall-component/ dir. - ViewportBlock: drop the unimplemented `implements IShape` clause and the now-unused IShape import. The class did not honor the contract (missing subElements2D / subElements3D); the declaration was misleading. - single-wall.ts and poly-wall.ts: drop `transparent: false` and `opacity: 1` from the options bag passed to solid.subtract(). opengeometry 2.0.9's BooleanExecutionOptions only accepts color, outline, fatOutlines, outlineWidth, kernel — both removed fields match the kernel defaults, so runtime behavior is unchanged. Verified: `npx tsc --noEmit` exits 0, `npm run build` green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
npx tsc --noEmitto a clean exit (was exiting with code 2 and 122 lines of errors). Prerequisite for adding a CI workflow that enforces typecheck on every PR.What changed
tsconfig.json— addexcludeforsrc/.../elements/catalog/../shared/dual-view/../shared/geometrymodules (~115 TS errors). The dir'sindex.tsalready has everyexport *commented out, so the files are not part of any build output. Full deletion of the directory deferred to a later PR.src/.../solids/wall-component/wall-engine.ts(and the now-emptywall-component/dir)src/orexamples/, and method bodies are stubs (no real logic).ViewportBlock— dropimplements IShapeclause and unusedIShapeimportsubElements2D/subElements3D). Declaration was misleading; the runtime behavior is unchanged.single-wall.tsandpoly-wall.ts— removetransparent: falseandopacity: 1from the options bag passed tosolid.subtract()opengeometry@2.0.9'sBooleanExecutionOptionsonly acceptscolor,outline,fatOutlines,outlineWidth,kernel. Removed fields match kernel defaults; no behavioral change.Verification
npx tsc --noEmit— exits 0 (was 2, 122 lines of errors)npm run build— green,created dist/ in ~1.1ssingle-wall.html,polyline-wall.html,wall-opening.html)Notes
🤖 Generated with Claude Code