chore: track build scripts in version control#70
Merged
Conversation
Removes the blanket scripts/ ignore that prevented fresh clones from running release/thumbnail commands. Tracks the three build-related files: - scripts/generate-thumbnails.js - scripts/prepare-dist-package.mjs - scripts/thumbnail-generator.html One optional maintainer-only file in scripts/ remains gitignored by name; vite.config.js now skips it gracefully when absent so contributors can build without it. Note: scripts/generate-thumbnails.js references catalog 2D classes that do not currently exist in src/. Pre-existing condition tracked separately, not addressed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the blanket
scripts/ignore from.gitignoreand commits the three build-related files inside the directory:scripts/generate-thumbnails.jsnpm run generate-thumbnailsscripts/prepare-dist-package.mjsnpm run release(pre-prepare)scripts/thumbnail-generator.htmlOne optional maintainer-only file in the directory stays gitignored by name.
vite.config.jsnow checks for its presence and skips the corresponding plugin when it's absent, so contributors can build examples without needing it locally.Why
package.jsonandvite.config.jsboth reference files insidescripts/. With the directory fully gitignored, fresh clones could not run release or build steps.Test plan
npm run build(rollup) — greennpm run releasereaches the publish step (without actually publishing)npm run build-examplesworks without the optional file present (note: there is a separate pre-existing issue withexamples/src/demo.htmlthat is unrelated to this PR)Notes
scripts/generate-thumbnails.jsreferences catalog 2D classes that don't currently exist insrc/. Pre-existing condition; tracked separately, not addressed here.🤖 Generated with Claude Code