feat: add CustomGridLineManager and OpenPlans grid-line API#40
Open
aka-blackboots wants to merge 1 commit into
Open
feat: add CustomGridLineManager and OpenPlans grid-line API#40aka-blackboots wants to merge 1 commit into
aka-blackboots wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OpenPlansso callers can create, update, query and remove reference grid lines programmatically.Description
src/service/custom-grid-lines.tsimplementingCustomGridLineManagerwith typed options (CreateGridLineOptions,UpdateGridLineOptions,GridLineData) and reasonable defaults for style and label properties.axisLockconstraints, geometry/material disposal on updates/removal, and scene-layer ownership via aGroupnamedcustom-grid-lines.Glyphs.addGlyphfor midpoint placement and rotation along the line direction, and synced label visibility with the line state.OpenPlans(src/index.ts) by instantiatingCustomGridLineManagerand exposingcreateReferenceGridLine,updateReferenceGridLine,removeReferenceGridLine,getReferenceGridLine,clearReferenceGridLines, and thereferenceGridLinesgetter.Testing
npm run buildto validate compilation which failed due to pre-existing repository issues (unresolved../kernel/imports and a TypeScriptTS5096config warning) that are unrelated to the new files and APIs.create/update/remove/get/list/clearpaths were exercised during development by creating and updating entities in the running environment (manual validation).Codex Task