Skip to content

deploy: support webhook_response in triggers#1393

Draft
midigofrank wants to merge 1 commit intomainfrom
support-trigger-webhook-response
Draft

deploy: support webhook_response in triggers#1393
midigofrank wants to merge 1 commit intomainfrom
support-trigger-webhook-response

Conversation

@midigofrank
Copy link
Copy Markdown
Contributor

Short Description

Support webhook_response in webhook triggers

Fixes #1351

Depends on OpenFn/lightning#4666

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@midigofrank midigofrank self-assigned this Apr 29, 2026
@github-project-automation github-project-automation Bot moved this to New Issues in Core Apr 29, 2026
@theroinaochieng theroinaochieng moved this from New Issues to In progress in Core Apr 29, 2026
@josephjclark
Copy link
Copy Markdown
Collaborator

Hey @midigofrank - this looks fine for v1, will need a pnpm changeset to track the changes.

We need to see some tests for this for v2, and think about versioning. We could spin this out into a new issue.

Check out integrations-tests/cli/test/deploy.v2.test.ts. @doc-han can help you navigate. Use pnpm exec ava test/deploy.v2.test.ts to just run that file.

Note that the integration tests mostly use the provisioner state format - define a project in provisioner state, then pull it down, then assert on the local structure.

Any changes on a trigger that affect versioning need to be written to the trigger node (and the version algorithm will need updating on both ends, come to think of it). If it doesn't affect versioning, the new keys should spread onto the .openfn key on the trigger.

You can probably just add the new keys to one of the existing structures, but it might make sense to create a dedicated test. I'm happy either way.

The other way of looking at this would be to add unit tests to packages/project, ensuring the keys are properly serialized in to-app-state.ts and from-app-state.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Support custom webhook responses in the cli

4 participants