revert: move Request.Body streaming breaking changes off master, they belong to 14.x#3409
Merged
Merged
Conversation
… belong to 14.x Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts the
Request.Bodystreaming breaking changes from master (the 13.x line):f9159cfa—feat!: make feign.Request.Body streaming-ready): restoresRequest.create(HttpMethod, String, Map, byte[], Charset),Request.body()returningbyte[],RequestTemplate#body(String)/body(byte[], Charset), removesMIGRATION-v14.mdand the japicmp excludes that bypassed the binary-compatibility gate.What is kept
Http2ClientTestrewrite from Fix feign-core test compilation broken by removed Request.create overload #3406 (API-independent): tests no longer call the livehttps://nghttp2.org/httpbin/service, which was silently hangingpr-build/snapshotfor 10+ minutes whenever that service degraded. MockWebServer rejects GET-with-body, so that one test uses a minimal local socket server.requestUriTemplate()) — additive, stays on master.Why
#3395 was meant for the
14.xbranch but was opened against master (the default base).14.xalready contains the streaming work via the last master→14.x merge, so nothing needs porting.This revert commit must NOT be applied to
14.x— a plain merge would undo the streaming work there. Revert this revert in the merge commit, or resolve conflicts toward the 14.x side for the affected files.Verified locally with a full
mvn verify(all 55 modules green).🤖 Generated with Claude Code