[Issue 1487] Fix ErrorDecoder not invoked for Apache HttpClient checked exceptions#3338
Open
gitshabh wants to merge 1 commit intoOpenFeign:masterfrom
Open
[Issue 1487] Fix ErrorDecoder not invoked for Apache HttpClient checked exceptions#3338gitshabh wants to merge 1 commit intoOpenFeign:masterfrom
gitshabh wants to merge 1 commit intoOpenFeign:masterfrom
Conversation
b0a9252 to
1c47c11
Compare
Author
|
@velo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Apache HttpClient throws checked exceptions like ProtocolException (e.g., missing Location header on 303 redirect), the ErrorDecoder was never invoked because the exception occurred during client.execute() before a Response object was created.
Root Cause
The ErrorDecoder interface requires a Response object: [Exception decode(String methodKey, Response response)]. When execution fails with checked exceptions, there's no Response to pass, causing the exception to propagate uncaught and potentially get wrapped in UndeclaredThrowableException.
Solution:
Build Response with appropriate status codes in case of ProtocolException instead of throwing exception so that error decoder can be invoked.