Conversation
Signed-off-by: rherrell <russ.herrell@hpe.com>
Signed-off-by: rherrell <russ.herrell@hpe.com>
Signed-off-by: rherrell <russ.herrell@hpe.com>
Signed-off-by: rherrell <russ.herrell@hpe.com>
Signed-off-by: rherrell <russ.herrell@hpe.com>
Signed-off-by: rherrell <russ.herrell@hpe.com>
rherrell
requested review from
cayton,
christian-pinto and
mjaguil
and removed request for
christian-pinto
Collaborator
Author
|
tests don't pass due to pre-test directory setups that are incorrect. |
…he agent upload test Signed-off-by: rherrell <russ.herrell@hpe.com>
Collaborator
Author
|
I have fixed the directory initialization problems associated with the new agent registration and agent upload events now tested. |
rherrell
commented
Mar 23, 2026
Collaborator
Author
rherrell
left a comment
rherrell
left a comment
There was a problem hiding this comment.
review complete with directory fixes working, and pytest scripts passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
have added the ResourceChanged event handler. Have also fixed a few bugs found in the process. Also, have added a test for the ResourceCreated event and the AggregationSourceDiscovered event ( testing agent registration and agent upload flows)
Still need to add a core lib test for the ResourceChanged event handler, but that involves re-thinking the existing tests and their templates and the initial Resources list, so I want to get the ResourceChanged handler into the main branch now.