Repository navigation
Conversation
…CnMax/CnMin airfoil parameters, IAG OtherState vortex variables, and updated continuous-state documentation
…nctions, CnMax/CnMin) to AirfoilInfo with summary-table output
…Data and udpate documentation
…Cc output channel is not comparable with UA_Mod=4/5
…ts instead of silently returning alphaF=0
bjonkman
reviewed
Oct 6, 2026
| typedef ^ ^ ReKi Ka - - - "IAG model: impulsive (non-circulatory) normal-force gain [default=0.75]" - | ||
| typedef ^ ^ ReKi Kv - - - "IAG model: center-of-pressure amplitude for vortex moment [default=0.2]" - | ||
| typedef ^ ^ ReKi dCNdA - - - "IAG model: static normal-force curve slope from linear-fit approach" 1/rad | ||
| typedef ^ ^ ReKi CnMax - - - "IAG model: (calculated) maximum static Cn, used as positive CN_CRIT" - |
Contributor
There was a problem hiding this comment.
I haven't looked through this code very carefully, but I'm curious if CnMax and CnMin are the same things as Cn1 and Cn2? Their descriptions seem very similar.
bjonkman
reviewed
Oct 6, 2026
| ! These are PROTECTED: only UA_SetIAGBlendBounds may modify them, and it is intended for | ||
| ! test/verification use. They are global (not per-instance), so a driver that changes them | ||
| ! changes them for every UA instance in the process. | ||
| real(ReKi), parameter :: IAG_BlendLo_Def = 30.0_ReKi ! deg; default start of the dynamic->static blend |
Contributor
There was a problem hiding this comment.
I'm not really a fan of storing these parameters in units of degrees. We generally store everything else in the code as radians. If they have to be in degrees, it would be nice to rename them to clearly indicate that they have non-standard units. like IAG_BlendLo_Def_deg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is not ready to be merged.
All tests pass (comment line changes only); all development is finished; documentation has been updated
Feature or improvement description
Related issue, if one exists
#2289
Impacted areas of the software
Generative AI usage
Generative AI was used in this work
Test results, if applicable
No impact on r-test results (changes to comment lines only)
To be completed before merging