Fix label matching in GetLineToWrite to avoid false matches in filenames#54
Open
TnR2 wants to merge 1 commit into
Open
Fix label matching in GetLineToWrite to avoid false matches in filenames#54TnR2 wants to merge 1 commit into
TnR2 wants to merge 1 commit into
Conversation
Use regex with \<...\> word boundaries instead of simple strfind to locate parameter labels as independent fields. This prevents incorrect matching when a label string appears inside a quoted filename. If the regex pattern fails to match, falls back to the original strfind result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Use regex with <...> word boundaries instead of simple strfind to locate parameter labels as independent fields. This prevents incorrect matching when a label string appears inside a quoted filename.
If the regex pattern fails to match, falls back to the original strfind result.
Example:
Before (incorrect matching):
Template line:
"IEA-10.0-198-RWT_InflowFile.dat" InflowFile - Name of file containing...
strfind matches "InflowFile" inside the filename first, resulting in:
"OF_WT_InflowFile.dat" InflowFile.dat" InflowFile - Name of file...
After (correct matching):
regex <...> matches only the standalone "InflowFile" label, resulting in:
"OF_WT_InflowFile.dat" InflowFile - Name of file containing...