feat(tIED): update internal object references on IED rename #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I've tested this by successfully loading a file on a device after doing a rename. Previously this didn't work with SEL Architect and it at least loads successfully on the device now and publishes GOOSE messages so it looks like the parser is happy. I would be most grateful for a detailed review and happy to make improvements. My implementation is designed to short-circuit as quickly as possible and to be fault tolerant. I think the code coverage is looking good. Once we agree on this PR I would be most pleased if we could also do:
|
JakobVogelsang
approved these changes
Feb 22, 2025
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125
Not quite implemented as I thought on the issue but I hope this is better.