chore: override playwright version #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this work! Can you see why visual regression tests would be failing here while they are still green on the parent commit? |
|
@stee-re : The "update screenshots" workflow in this repo can only be triggered manually, and it seems to have been disabled on your fork. Hence I do not know how to update the screenshots on this so that it might pass review. |
stee-re
force-pushed
the
ci_fix-playwright-version
branch
from
b39122c to
bfc2ce2
Compare
playwright shipped with open-wc is old and is not supported with Ubuntu 24.04
stee-re
force-pushed
the
ci_fix-playwright-version
branch
2 times, most recently
from
e9786db to
ebc20c5
Compare
Author
|
@ca-d I experienced the exact same test errors here when playwright worked again - namely the "displays a menu on button click" failing on webkit in German. Added the same fixes here as I did in the other repo to fix this here. |
stee-re
force-pushed
the
ci_fix-playwright-version
branch
3 times, most recently
from
4909922 to
1979e8f
Compare
stee-re
force-pushed
the
ci_fix-playwright-version
branch
from
1979e8f to
596d6bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playwright shipped with open-wc is old and is not supported with Ubuntu 24.04
This is a small fix to override the stock version of playwright shipped with open-wc to a newer version which is supported on Ubuntu 24.04.
This fix was originally applied on OmicronEnergyOSS/open-scd-core - so its tried and tested.