Repository navigation
Conversation
Update battery registration with power-policy routing. Share TimeAlarm wake config and GPIO handling so other platforms can reuse the logic without depending on QEMU's HAL.
tullom
requested review from
RobertZ2011,
dymk,
felipebalbi,
jerrysxie,
kat-perez,
kurtjd,
maxperga-msft and
rogurr
and
a balanced review from Copilot
November 10, 2026 21:43
tullom
enabled auto-merge (squash)
November 10, 2026 21:44
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the dependency refresh and shared mock-service updates.
No open issues 🎉
What changed in this PR
Updates embedded-service dependencies and adapts the shared mock services to the new APIs, making TimeAlarm wake handling reusable beyond QEMU.
Changes:
- Refresh dependency revisions across all six lockfiles.
- Add default power-policy routing to mock battery registration.
- Extract HAL-independent TimeAlarm configuration and GPIO helpers, and use them from QEMU.
| File | Description |
|---|---|
platform/platform-common/src/mock/time_alarm.rs |
Adds shared wake configuration, output driving, and power-input monitoring. |
platform/platform-common/src/mock/battery.rs |
Registers batteries with default power-policy routing. |
platform/platform-common/Cargo.lock |
Updates shared-library service dependencies. |
platform/dev-qemu/src/main.rs |
Delegates TimeAlarm handling to shared helpers. |
platform/dev-qemu/Cargo.lock |
Updates QEMU service dependencies. |
platform/dev-npcx/Cargo.lock |
Updates NPCX service dependencies. |
platform/dev-mec/Cargo.lock |
Updates MEC service dependencies. |
platform/dev-mcxa/Cargo.lock |
Updates MCXA service dependencies. |
platform/dev-imxrt/Cargo.lock |
Updates i.MXRT service dependencies. |
Review effort: Balanced
kurtjd
approved these changes
Nov 10, 2026
RobertZ2011
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update battery registration with power-policy routing.
Share TimeAlarm wake config and GPIO handling so other platforms can reuse the logic without depending on QEMU's HAL.